Suzie1 / ComfyUI_Comfyroll_CustomNodes

Custom nodes for SDXL and SD1.5 including Multi-ControlNet, LoRA, Aspect Ratio, Process Switches, and many more nodes.
https://civitai.com/models/183551/comfyui-comfyroll-custom-nodes
631 stars 85 forks source link

CR text List error #192

Open IMParesqui opened 1 month ago

IMParesqui commented 1 month ago

When using CR text list I'm getting the following error: This happens when using with and withou a multiline text input. Captura de tela 2024-08-07 105803

Error occurred when executing CR Text List:

CR_TextList.make_list() missing 1 required positional argument: 'loops'

File "C:\AI\Images\ComfyUI_windows_portable\ComfyUI\execution.py", line 152, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\AI\Images\ComfyUI_windows_portable\ComfyUI\execution.py", line 82, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\AI\Images\ComfyUI_windows_portable\ComfyUI\execution.py", line 75, in map_node_over_list results.append(getattr(obj, func)(**slice_dict(input_data_all, i))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

colinmorris commented 1 month ago

See #116. The solution is just to remove the parameter loops from line 79, since it's not used in the code.

veighnsche commented 1 month ago

But why is that the solution while it could be in the main branch?