search

Suzie1 / ComfyUI_Comfyroll_CustomNodes

Custom nodes for SDXL and SD1.5 including Multi-ControlNet, LoRA, Aspect Ratio, Process Switches, and many more nodes.
https://civitai.com/models/183551/comfyui-comfyroll-custom-nodes
635 stars 87 forks source link

Fixed duplicate RETURN_TYPES def #58

Closed rbfussell closed 10 months ago

rbfussell commented 10 months ago

Duplicate RETURN_TYPE overwrote previous declaration in nodes/conversion.py:

74: RETURN_TYPES = (any, "STRING", ) 75: RETURN_TYPES = ("any", "show_help", )

invalidating the any output as string "any" instead of AnyType("*") '

removed 75 for this pull.

RockOfFire commented 10 months ago

Thank you for finding this issue! Line 75 was supposed to be RETURN_NAMES, I made a mistake when adding all of those. I'll accept the PR and then make sure it's RETURN_NAMES.

rbfussell commented 10 months ago

the problem would have been okay as just duplicates, but the second duplicate had an error quote enclosing the - any - var, which now became "any" which was just a dead output. It took me a while to figure out what was going on cos... it is "any" but any is not "any," but the labeling of the output threw me cos... is any, so the name any made sense. Glad to help.