conversion.py issue with String to Integer

[fidecastro]

@Suzie1 it seems the def convert is missing the round_integer call for the CR String to Number call. I'm working around it by just adding round_integer = "round_up" in the function call.

[Suzie1]

Oh sorry, i may have missed something in my test cases. I will check it tomorrow. Thanks for reporting it. Suzie

[Suzie1]

hi, I retested the node today with my test cases and couldn't see a problem Https://github.com/Suzie1/ComfyUI_Comfyroll_CustomNodes/wiki/Conversion-Nodes#cr-string-to-number I may be missing something Please can you let me know your scenario, the expected result, and the actual result thanks Suzie

[fidecastro]

Maybe it was an issue with already existing workflows? The workflows were bricked because the conversion node took 1 more positional arguments than it was being given (the offending one being the round_integer argument).

[Suzie1]

Yes, that may be the explanation, when parameters are added to a node they often need reloading. Try deleting the node and replacing it again. Let me know if this works.

On Fri, 22 Dec 2023, 05:37 fidecastro, @.***> wrote:

Maybe it was an issue with already existing workflows? The workflows were bricked because the conversion node took 1 more positional arguments than it was being given (the offending one being the round_integer argument).

— Reply to this email directly, view it on GitHub https://github.com/Suzie1/ComfyUI_Comfyroll_CustomNodes/issues/77#issuecomment-1867263974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKBKY7OWZXBQK5PCE3WDKOLYKUMB7AVCNFSM6AAAAABA3V6YEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRXGI3DGOJXGQ . You are receiving this because you were mentioned.Message ID: @.***>

[fidecastro]

Will do. Thanks!

[Suzie1]

hi, i'm cloing this for now, if the issue reoccurs please let me know