replace "_float float_ int_ " with "float int"

Suzie1 / ComfyUI_Comfyroll_CustomNodes

Custom nodes for SDXL and SD1.5 including Multi-ControlNet, LoRA, Aspect Ratio, Process Switches, and many more nodes.

https://civitai.com/models/183551/comfyui-comfyroll-custom-nodes

634 stars 87 forks source link

replace "_float float_ int_ " with "float int" #94

Open DorotaLuna opened 9 months ago

DorotaLuna commented 9 months ago

Why there would be a _ in the name?

Suzie1 commented 9 months ago

good question, i'll test it without :)

Suzie1 commented 9 months ago

hi, i did some tests and it looks like this change would be workflow breaking this means that workflows using these nodes would need to be changed, and workflows attached to images would also not run without changes i agree this would be a good change, but it could impact too many people normally i make changes like this within the first two weeks of the node being released, before it becomes widely used Suzie

Suzie1 commented 8 months ago

Hi, DrLtData is planning changes to make it easier to update nodes. I'll keep this PR open and may implement it once these changes have been made. Suzie