Volume slider breaking at certain window width

Iftuga commented 2 months ago

Checklist:

[x] I checked here if there is already an issue for this bug
[x] I am using the latest version of BetterYTM
[x] I am using the latest version of my browser
[x] I was able to reproduce the bug while all my other userscripts or extensions were disabled

Description of the bug and steps to reproduce:

At a certain window width, the enhanced volume features stop working. For example, I have the volume set to increase/decrease by 1% on scrolling, and when I reduce the width of a window with ytm (to fit my second monitor, which is in vertical position), the scroll increase/decrease reverts to 10%, and when I increase the width of the window again, it works again at 1%. The threshold seems to be around 1000px in width.

Environment:

Browser name & version: Chromium 126.0.6478.231
Userscript version & build number: v2.0.0 (#f449995a)

Sv443 commented 2 months ago

Thanks for submitting the bug!
Yeah it looks like YTM is switching to a different element if the screen width is too small and I haven't added my volume features to this secondary volume slider element.
Should be an easy-ish fix, but I'll see if I can do it in v2.1 or in a patch to that version.

Sv443 commented 2 months ago

I just fixed this issue and if you want and until v2.1.0 is released, you could install the preview version here.
Once v2.1.0 is out, I will close this issue and you should manually remove and reinstall BetterYTM.

Iftuga commented 2 months ago

Checked the preview, works fine with small windows now, but I noticed this weird black thing that was not there before.

Sv443 commented 2 months ago

My bad, that's fixed now.

Sv443 commented 1 month ago

Hi again, I just released the new version 2.1.0 which includes this fix.
You can install it from GitHub, GreasyFork or OpenUserJS.

Sv443 / BetterYTM