search

SvanBoxel / delete-merged-branch

No more manually deleting merged branches, this lovely app does it for you.
https://github.com/apps/delete-merged-branch/
ISC License
323 stars 55 forks source link

feat(app): add a config to delete closed pr branch #107

Closed cyberhck closed 5 years ago

cyberhck commented 5 years ago

delete_closed_pr key on your yaml file will now also delete closed branches

closes #106

cyberhck commented 5 years ago

there's some CI issue, locally I found some styling issue I fixed those, you should soon fix the npmrc issue, maybe if it's not master, just delete npmrc file @SvanBoxel

cyberhck commented 5 years ago

@SvanBoxel I can try deleting .npmrc on not master branches and fix that if you'd like

cyberhck commented 5 years ago

@SvanBoxel can we instead have this default to deleting closed PRs as well? I'll do this, default value I'll let the env provide (so you can default to false if you'd like, and I'll default to 1 on my internal), and if you want to default to true, you can do so via env as well.

cyberhck commented 5 years ago

hey @SvanBoxel do you mind taking a look? Thanks.

SvanBoxel commented 5 years ago

Hey, sorry I completely missed this PR! Looks good from my side (ignoring the CI issue). Could you update the readme as well? Thanks!

cyberhck commented 5 years ago

I'll see if I can update env so I can set default to delete the merged branch as well :)

cyberhck commented 5 years ago

@SvanBoxel please check the latest version, if there's any styling issue, I'll fix it, other than that, it should be working perfectly same for you, but when I deploy my own instance for my private enterprise, I should be able to set a environment variable and delete also closed branches :)

Thanks.

cyberhck commented 5 years ago

@SvanBoxel hey, this is ready, in case you missed the last notification.

SvanBoxel commented 5 years ago

Good work @cyberhck 🚀