SvanBoxel / delete-merged-branch

No more manually deleting merged branches, this lovely app does it for you.

https://github.com/apps/delete-merged-branch/

ISC License

323 stars 55 forks source link

Docker improvements #56

Closed Graham42 closed 5 years ago

Graham42 commented 5 years ago

Don't bundle secrets in container
Improved docker build caching.
Made the Dockerfile more versatile so it can be used for a server or for testing.

Usage:

docker run -i -t --rm \
    -v "$(pwd)/.env:/app/.env" \
    delete-merged-branch \
        <probot-command> /app/index.js <params>

codecov[bot] commented 5 years ago

Codecov Report

Merging #56 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #56   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          26     26           
  Branches        3      3           
=====================================
  Hits           26     26

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f46322...daa5f20. Read the comment docs.

Graham42 commented 5 years ago

The build is failing with

sonar-scanner sonar-scanner: command not found The command "sonar-scanner" exited with 127.

This seems unrelated to my changes?

SvanBoxel commented 5 years ago

Hey @Graham42 ! Thanks for your contributions. I'm looking into the sonar-scanner error

SvanBoxel commented 5 years ago

@Graham42 I'm merging your pull request, this is a known issue with forks. https://docs.travis-ci.com/user/sonarcloud/#upcoming-improvements Thanks again!

SvanBoxel commented 5 years ago

:tada: This PR is included in version 1.3.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: