search

SvanBoxel / delete-merged-branch

No more manually deleting merged branches, this lovely app does it for you.
https://github.com/apps/delete-merged-branch/
ISC License
323 stars 55 forks source link

[feature-request] Setting to only delete for certain commiters #8

Closed Minipada closed 3 years ago

Minipada commented 6 years ago

First, thanks for the work, it looks amazing!

In my organization, I would be interested in it but not all members are. Could there be a setting to choose for whom it is enabled?

SvanBoxel commented 6 years ago

@Minipada Missed your issue, sorry for the late response! Could you tell me in more detail how this would - ideally - look for you? Do you want a configuration file? Do you want it to be based on tin which github-team someone is. Anything else? Thanks!

Minipada commented 6 years ago

Hey @SvanBoxel , thanks for the answer :). I was wondering, could we use your .env file so it stays as simple as it is now? It would be an optional parameters to pass github users/team

SvanBoxel commented 6 years ago

I assume you're not committing your .env file to GH because most of the time it contains sensitive information. So that's not a viable option for most people.

Minipada commented 6 years ago

Then, I'm good with what's the easiest for you, yaml file or any other would be great :+1:

SvanBoxel commented 6 years ago

Okay, let me dive into it this weekend. 🌮

AraHaan commented 6 years ago

Can the bot also be able to delete the branch off of forks too? or is that ability impossible without them authorizing the bot to write to their repositories?

Perhaps GitHub Should make it to where the people with write access to the original repositories also have write to the forks of their repositories so they can either update, or delete the PR branches upon merge.

SvanBoxel commented 3 years ago

Closing this feature request as it won't be implemented anytime soon. (Feel free to open a pr yourself if you want to see this functionality added)