Sveino / Inst4CIM-KG

Instance of CIM Knowledge Graph
Apache License 2.0
6 stars 1 forks source link

Header: `Resource1 ... Resource13`? #25

Open VladimirAlexiev opened 4 months ago

VladimirAlexiev commented 4 months ago

Header-AP-Voc-RDFS2020.ttl has 13 props that seem to be bugs:

Two of the 13:

dcat:Resource7  rdf:type      rdf:Property ;
        rdfs:comment          "The resoource of a previous version that has this next version." ;
        rdfs:domain           md:Model ;
        rdfs:label            "Resource7"@en ;
        rdfs:range            md:Model ;
        cims:AssociationUsed  "No" ;
        cims:inverseRoleName  dcat:previousVersion ;
        cims:multiplicity     cims:M:0..1 ;
        cims:stereotype       "dcat" .

dcat:Resource8  rdf:type      rdf:Property ;
        rdfs:comment          "The resource that has this next version." ;
        rdfs:domain           md:Model ;
        rdfs:label            "Resource8"@en ;
        rdfs:range            md:Model ;
        cims:AssociationUsed  "No" ;
        cims:inverseRoleName  dcat:nextVersion ;
        cims:multiplicity     cims:M:0..1 ;
        cims:stereotype       "dcat" .
VladimirAlexiev commented 3 months ago

In addition to wrong localnames, the comments of the above two are unnecessarily twisted. Use the wording from DCAT, eg

dcat:previousVersion rdfs:comment "The previous version of a resource in a lineage".
dcat:nextVersion rdfs:comment "The next version of a resource in a lineage".

Note: https://www.w3.org/TR/vocab-dcat-3/#inverse-properties intentionally doesn't define dcat:nextVersion (because inverses are redundant). But all CIM props use inverses, so it's ok for CIM to define it.

Sveino commented 2 months ago

All headers are updated in NC 2.3.1. Hopefully is this fixed.

VladimirAlexiev commented 1 month ago

These are still present: https://github.com/Sveino/Inst4CIM-KG/blob/develop/rdfs-improved%2FCGMES-NC%2Fttl%2FHeader-AP-Voc-RDFS2020.ttl#L106

griddigit-ci commented 1 month ago

We need discussion here.

VladimirAlexiev commented 1 month ago

The problems come from the desire to express DCAT terms.