search

Svelte-Sirens / svelte-sirens

The website for the Svelte Sirens. Svelte Society for women, non-binary people, & allies!
https://sveltesirens.dev/
GNU General Public License v3.0
30 stars 8 forks source link

Some +page.js should be +page.server.js #70

Closed ghostdevv closed 2 years ago

ghostdevv commented 2 years ago

Data should only be loaded on the server

lukeshafer commented 2 years ago

Hi @ghostdevv! I'd be happy to tackle this one!

ghostdevv commented 2 years ago

@lukeshafer Go for it!

lukeshafer commented 2 years ago

Huh it may have been taken care of already? I just see one +page.js in the calendar route, which is just doing a redirect! So we may be good here, unless I'm misreading/misunderstanding!

I'd love to help where needed though! I'll glance through the other issues to see

ghostdevv commented 2 years ago

Oh weird :/ Sorry about that! We could probably do with that +page.js being made a +page.server.ts though if you want to do that, I also marked #67 as a good first issue

If you have already done a fork make sure to update it, I pushed a couple changes that fix a couple errors we had that are important you get ;)

lukeshafer commented 2 years ago

Sounds good 😁 I'll update my fork and take a look at that one and I'll update that endpoint!

ghostdevv commented 2 years ago

thanks for all your help @lukeshafer