search

Svelte-Sirens / svelte-sirens

The website for the Svelte Sirens. Svelte Society for women, non-binary people, & allies!
https://sveltesirens.dev/
GNU General Public License v3.0
30 stars 8 forks source link

78 replaced @ aliases with $ #82

Closed vaishnav-mk closed 2 years ago

vaishnav-mk commented 2 years ago

Closes https://github.com/Svelte-Sirens/svelte-sirens/issues/78

I'm quite new to open source so do let me know if there's anything else that should be changed for this pr to be merged!

netlify[bot] commented 2 years ago

Deploy Preview for sveltesirens ready!

Name Link
Latest commit c652773faa361f3b6c89ebdfb0da6351139e605b
Latest deploy log https://app.netlify.com/sites/sveltesirens/deploys/6359ea5decf1950008f83bf5
Deploy Preview https://deploy-preview-82--sveltesirens.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

vaishnav-mk commented 2 years ago

oh lol, rookie mistake, my bad!

spences10 commented 2 years ago

Hey @vaishnav-mk I was enquiring with @brittneypostma about it, there wasn't any need to update the file until there was a bit of clarification around what to do.

As I mentioned the pnpm-lock.yaml was already in there, so it may have been a good catch on your part 😃

@brittneypostma are the lockfiles intended to be ignored?

I know there are some practices where removing them from the build is required, personally I always leave them in there as I've been burnt in the past with deps being included in the lockfiles.

Like I mentioned it's a preference and maybe something that could go into a .github/CONTRUBUTING.md file maybe?

brittneypostma commented 2 years ago

It isn't a preference and should be included for Netlify to build the site. Thanks for catching it! I think the rest of these look good as well.

brittneypostma commented 2 years ago

oh lol, rookie mistake, my bad!

Are you able to remove it from the pr? I'm on mobile for now and can't fix it until later. Thank you!

vaishnav-mk commented 2 years ago

oh lol, rookie mistake, my bad!

Are you able to remove it from the pr? I'm on mobile for now and can't fix it until later. Thank you!

i've removed pnpm-lock.yaml from .gitignore.

brittneypostma commented 2 years ago

oh lol, rookie mistake, my bad!

Are you able to remove it from the pr? I'm on mobile for now and can't fix it until later. Thank you!

i've removed pnpm-lock.yaml from .gitignore.

The pnpm-lock file is still not in, but I should be able to take care of that. Thank you for the updates. I'll merge and fix the lock issue.

spences10 commented 2 years ago

@brittneypostma if you have any issues with git not recognising the lockfile then maybe try git update-index --no-assume-unchanged pnpm-lock.yaml

spences10 commented 2 years ago

It should start tracking the file again 😊

Thanks for the contribution @vaishnav-mk 👍

vaishnav-mk commented 2 years ago

Oh, nice! Thanks for the opportunity, was fun making my first pr for a public project

brittneypostma commented 2 years ago

Should be in there now