Closed vaishnav-mk closed 1 year ago
Name | Link |
---|---|
Latest commit | 9f1b7e0d2c207929aa649e39fb47f26cc70785ca |
Latest deploy log | https://app.netlify.com/sites/sveltesirens/deploys/635fb0259d8df500084c77b4 |
Deploy Preview | https://deploy-preview-84--sveltesirens.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Thaks for the contribution @vaishnav-mk 👍
LGTM 😊
This shouldn't close #84 however.
There's a LICENCE
and CONTRIBUTING.md
that I feel should be added at the bare minimum before that can be closed, what are your thoughts on this @ghostdevv and @brittneypostma??
I'll sort the LICENSE out in a separate PR, I can't believe we don't have one! :scream: Re: CONTRIBUTING.md
I don't mind whether we have one or not, feel free to open a issue for that (we can do that in another PR if you get around to making an issue)
Yeah, sure. I think the whole reason I brought this up was that there was a bit of confusion with an initial PR from @vaishnav-mk where a CONTRIBUTING.md
could have helped clear up any uncertainty around the contribution that was made.
Oki we can definitely add that then, I see you mentioned it in your issue (#83) I missed that :sweat_smile: - lets do it in another PR! Happy for anyone to take that PR otherwise I will get to it end of this week
Going to merge this one :pray:
Added a link to svelte's CoC. This should resolve https://github.com/Svelte-Sirens/svelte-sirens/issues/83