search

SvelteStack / svelte-query

Performant and powerful remote data synchronization for Svelte
https://sveltequery.vercel.app
MIT License
813 stars 31 forks source link

feat(usequery): provide AbortSignal to queryFn #66

Closed anymaniax closed 2 years ago

anymaniax commented 2 years ago

I tried to retrofit the new query cancellation feature to svelte-query.

You can find the merge request on react-query here

andreasbhansen commented 2 years ago

@anymaniax What would you say is missing from this PR, seeing as you closed it in January? The improved AbortSignal in RQ would be a killer feature in SQ as request cancellation (at least architected somewhat clean) feels like a bit of a pain point at the moment.

anymaniax commented 2 years ago

@andreasbhansen it's already in the new version from what I saw

andreasbhansen commented 2 years ago

@anymaniax It seems you are absolutely right, I think the SQ query cancellation docs have simply not been updated to reflect this?