search

SvenKayser / JMOD

The Javascript MOD Loader
Other
9 stars 4 forks source link

Bugfix for issue #38 #39

Closed nmarshall23 closed 7 years ago

nmarshall23 commented 7 years ago

JMOD was using Nashorn to parse Json. Now using Gson to parse the JMODInfo file.

I was wrong about the cause of this bug. In JRE 8u60 a feature was added to Nashorn to parse json into Java Objects.

SvenKayser commented 7 years ago

Well I'm not sure if I want that.

The difference between Nashorn parsing and Gson parsing is that Nashorn parses actually a "true" javascript file that allows comments, while Gson does not. Because, interestingly: It used to be done with Gson before. I'll have to give this some thought.

SvenKayser commented 7 years ago

Went into indev as I cannot merge this into master without further building upon this as it would break most jmods reteo is using.