Detail button was missing on iPad in landscape

SvenTiigi / WhatsNewKit

Showcase your awesome new app features 📱

https://sventiigi.github.io/WhatsNewKit/

MIT License

3.92k stars 193 forks source link

Detail button was missing on iPad in landscape #16

Closed BenBeng closed 5 years ago

BenBeng commented 5 years ago

I was running the demo on iPad Pro 11 simulator(iOS 12), and the detail button was missing when iPad was in landscape, and split mode.

Also, I found the items view was too left, and the completion button was too long when using on iPad in landscape. Maybe you can give an option to use tableView.cellLayoutMarginsFollowReadableWidth = true and some other layout change to make it more readable on iPad.

simulator screen shot - ipad pro 11-inch - 2019-01-31 at 23 53 40

SvenTiigi commented 5 years ago

Hi @BenBeng

Thanks for your bug report 🙌

I've just created an Feature Branch ipad-layout which will be used to improve the WhatsNewKit layout in general and in especially for the iPad.

Feel free to open a PR on this Branch.

SvenTiigi commented 5 years ago

Hey @BenBeng

Please have a look at the new Release 1.1.6

It contains an improved Layout for iPhone/iPad and API's to configure the Layout insets to your needs.

simulator screen shot - ipad air 2 - 2019-02-02 at 14 34 29