[iOS 13] ItemsView scrollview too large when using content Mode .fill or .center

mattbarker016 commented 5 years ago

WhatsNewKit Environment

WhatsNewKit version: 1.2
Xcode version: Xcode-beta 11.0 beta 5
Swift version: Swift 5
macOS version running Xcode: macOS 10.14.6
Dependency manager (Carthage, CocoaPods, Manually): CocoaPods

What did you do?

Launched the WhatsNewViewController in iOS 13 with a itemsView.contentMode of .center or .fill.

What did you expect to happen?

All the items to fit on the screen.

What happened instead?

The itemsView scrollView went off the screen, with too much space between each itemView. The below screenshots are using an .fill with some insets for the itemsView on an iPhone XR simulator.

iOS 12.2

iOS 13.0

SvenTiigi commented 5 years ago

Hey @mattbarker016

Thanks for your bug report 👍

I will definitely have look at this with the newest Xcode 11 beta to find a solution for it.

SvenTiigi commented 5 years ago

Hey @mattbarker016

Please check out the branch feature/iOS-13 I've pushed a bug fix for your reported problem.

Let me know if this bug fix works for you ✌️

mattbarker016 commented 5 years ago

Yep, works great!

SvenTiigi / WhatsNewKit