CompletionButton Height

SvenTiigi / WhatsNewKit

Showcase your awesome new app features 📱

https://sventiigi.github.io/WhatsNewKit/

MIT License

3.87k stars 190 forks source link

CompletionButton Height #25

Closed zboralski closed 5 years ago

zboralski commented 5 years ago

It would be nice to be able to set the height of the completion button. If the goal of this project was to be consistent with the welcome screens that were added to Apple's own apps then the completion button is way too tall.

zboralski commented 5 years ago

@SvenTiigi could you make the completion button's interface accessible ?

zboralski commented 5 years ago

I switched to the feature/button-customization branch and used the following configuration to match iOS 13's Welcome Screen style:

config.completionButton.titleFont = .systemFont(ofSize: 16)
config.completionButton.insets.bottom = 50
config.completionButton.cornerRadius = 12
config.completionButton.customization = { button in
    button.contentEdgeInsets.bottom = 11
    button.contentEdgeInsets.top = 11
}

SvenTiigi commented 5 years ago

Hey @zboralski,

I'm looking forward to merge the feature/button-customization branch soon to the master branch so that you can switch to an official release 👌

SvenTiigi commented 5 years ago

Hey @zboralski

FYI: The branch feature/iOS-13 now contains the latest design update according to the current iOS 13 style.

zboralski commented 5 years ago

The height of the continue button is much smaller in iOS 13 though.