search

SvenTiigi / WhatsNewKit

Showcase your awesome new app features 📱
https://sventiigi.github.io/WhatsNewKit/
MIT License
3.92k stars 193 forks source link

Animations & iOS 13 #26

Closed jminutaglio closed 5 years ago

jminutaglio commented 5 years ago

WhatsNewKit Environment

What did you do?

In the iOS 13 beta, the animations in WhatsNewKit don't show (due to changes in 13 and how push screens are rendered)

What did you expect to happen?

using: self.present(whatsNewViewController, animated: true)

in 12x - animations are fine in 13x - animations do not render

using: self.navigationController?.pushViewController(whatsNewViewController, animated: true) in 13x - animations are fine, but "back" is displayed at top of whatsNewViewController

SvenTiigi commented 5 years ago

Hey @jminutaglio,

Thanks for your bug-report 👍

Please check out the iOS-13 feature branch which now contains a fix that the animations are triggered correctly when the WhatsNewViewController is presented in iOS 13.

jminutaglio commented 5 years ago

ty! the 13 branch resolved what I was seeing. (and fixes some other general layout issues) - looks great.

jminutaglio commented 5 years ago

do you plan to merge the 13 branch back here when 13 comes out? And/or what is the release plan to get the fixes in the main branch? (so updates can come via Cocoapods?). ty!

SvenTiigi commented 5 years ago

Hey @jminutaglio,

Please check out the latest release 1.3.0 🥳

jminutaglio commented 5 years ago

thank you so much!!! Your kit is awesome!!!!