search

SvenTiigi / WhatsNewKit

Showcase your awesome new app features 📱
https://sventiigi.github.io/WhatsNewKit/
MIT License
3.87k stars 190 forks source link

Page indicator #3

Closed Pe-te closed 6 years ago

Pe-te commented 6 years ago

Hi, very nice library. Is there a way to show a page indicator in the slides?

SvenTiigi commented 6 years ago

Hey @Pe-te,

Thanks for your appreciation 🙌

Could you explain your issue / feature-request in detail?

Currently the visible Features aka. WhatsNew.Item are visualized in a UITableView and can only been scrolled vertically. There is currently no horizontal scrolling available which would open the need of a PageIndicator.

Pe-te commented 6 years ago

Oh okay, maybe I misunderstood the animation on the github page? It's just showing the different designs? It looked like it swipes from one page to the next.

We want to show multiple slides, each with a tableview and the user should be able to swipe between the slides, both forward and backwards.

SvenTiigi commented 6 years ago

Yes the example GIF just showing different designs of a WhatsNewViewController which were pushed via a UINavigationController during screen recording.

If I understood your correctly you want to change the scrolling behaviour of the UITableView where your new Features are visualized from vertical to horizontal. To do so the UITableView should be refactored to a UICollectionView in order to manipulate the layout.

Or you can simply put multiple WhatsNewViewControllers into a UIPageViewController in order to swipe between multiple pages.

Pe-te commented 6 years ago

Or you can simply put multiple WhatsNewViewControllers into a UIPageViewController in order to swipe between multiple pages.

Yes, that's what we are after, from the animation it just looked like it already does it. I'll give it a try, thanks!

SvenTiigi commented 6 years ago

Feel free to open a PR to extend WhatsNewKit 🙌