search

SvenTiigi / WhatsNewKit

Showcase your awesome new app features 📱
https://sventiigi.github.io/WhatsNewKit/
MIT License
3.87k stars 190 forks source link

Colors do not respond to runtime changes to device Dark Mode setting #32

Closed feodormak closed 4 years ago

feodormak commented 4 years ago

WhatsNewKit Environment

What did you do?

ℹ

  • Configured completion button background colour with my own custom UIColor instance supporting Dark Appearance
  • Change the device Dark appearance setting in Simulator via Settings & Xcode Environment Overrides

What did you expect to happen?

ℹ Colours to update to the corresponding dark/light appearance shade

What happened instead?

ℹ Completion button background colour remained in the colour it was initialised with.

SvenTiigi commented 4 years ago

Hey @feodormak,

Thanks for your bug report.

I've pushed a fix https://github.com/SvenTiigi/WhatsNewKit/commit/704c647c90b4a50e683468ed8827d0b5b357fd27 on the develop branch.

Please checkout the develop branch and let me know if this resolve your issue.

pod 'WhatsNewKit', :git => 'https://github.com/SvenTiigi/WhatsNewKit.git', :branch => 'develop'

If everything works fine the fix will be included in the next release of WhatsNewKit 👌

feodormak commented 4 years ago

Hi @SvenTiigi , Thanks for the quick fix, it works, but from what I see, it is not limited to the completion button. The images of the Items are not changing colors too.

SvenTiigi commented 4 years ago

Hey @feodormak,

Thanks for your feedback please try it again with the latest commit of the develop branch

feodormak commented 4 years ago

@SvenTiigi , it works! thanks for the quick updates!

SvenTiigi commented 4 years ago

Perfect 👍

The fix will be included in the next release of WhatsNewKit