search

SvenTiigi / WhatsNewKit

Showcase your awesome new app features 📱
https://sventiigi.github.io/WhatsNewKit/
MIT License
3.87k stars 190 forks source link

Feature Request | Padding inside of ItemView #50

Closed Britishfrog closed 2 years ago

Britishfrog commented 3 years ago

Hi Sven!

Love the framework for this :D Was wondering if there was a way to affect the padding inside of each ItemView?

Thanks!

SvenTiigi commented 3 years ago

Hi @Britishfrog

Thanks for your bug report.

Currently WhatsNewKit is limited to either adjust the insets of the ItemsView itself via: https://github.com/SvenTiigi/WhatsNewKit/blob/2750b869363652b178eee757f54b5e7063a93ebc/Sources/Configuration/WhatsNewViewController%2BItemsView.swift#L46

or setting the contentMode to .center to increase the spacing between each cell. https://github.com/SvenTiigi/WhatsNewKit/blob/2750b869363652b178eee757f54b5e7063a93ebc/Sources/Configuration/WhatsNewViewController%2BItemsView.swift#L40

But it would be a great addition to configure the spacing between each cell. I will check if this feature can be added to the next release of WhatsNewKit 👌

Britishfrog commented 3 years ago

Excellent stuff! Very excited about this showing up in the next release :) For now my workaround is using new lines strategically through the descriptions and titles.

On a separate note, I noticed that images set when contentMode is .center tend to clip over a certain size. It would be nice if the images were constrained inside of the tableview so that they aspect fit. No pressure though ;)

SvenTiigi commented 2 years ago

Hi @Britishfrog,

WhatsNewKit has been updated to a new major version 2.0.0 with extended support for SwiftUI, UIKit and AppKit.

The new version includes some major breaking changes but also a new WhatsNew.Layout API which allows you to customize the padding/spacing between the presented features

// Increase the spacing of the feature list
WhatsNew.Layout.default.featureListSpacing = 100

You can find more information about the new Layout API in the README.md.