SvenTiigi / WhatsNewKit

Showcase your awesome new app features 📱
https://sventiigi.github.io/WhatsNewKit/
MIT License
3.92k stars 193 forks source link

Truncated text on iOS 14 #52

Closed AndrewBennet closed 2 years ago

AndrewBennet commented 2 years ago

WhatsNewKit Environment

What did you do?

Presented a WhatsNewKit view controller on a iOS 14 simulator

What did you expect to happen?

The text to not be truncated.

What happened instead?

The text was truncated. See attached screenshot.

Screenshot 2022-01-09 at 11 32 41

Produce by using the following code:

WhatsNewViewController(whatsNew:
    WhatsNew(
        title: .init(text: .init("Whats New in Reading List")),
        features: [
            .init(
                image: .init(systemName: "shuffle"),
                title: .init("Shake to Choose"),
                subtitle: .init("Shake your device to choose your next book")
            ),
            .init(
                image: .init(systemName: "hammer.fill"),
                title: .init("Improvements and Fixes"),
                subtitle: .init("Various performance improvements and bug fixes")
            )
        ]
    )
)

Note, this does not occur on iOS 15 simulators. I have seen similar issues in SwiftUI before, requiring the use of .fixedSize()...

SvenTiigi commented 2 years ago

PR https://github.com/SvenTiigi/WhatsNewKit/pull/53 has been merged