search

SvenTiigi / WhatsNewKit

Showcase your awesome new app features 📱
https://sventiigi.github.io/WhatsNewKit/
MIT License
3.92k stars 193 forks source link

Background color surrounding primary action button does not match rest of background color #85

Closed gaw3 closed 4 months ago

gaw3 commented 5 months ago

What happened?

RocketSim_Screenshot_iPhone_15_6 1_2024-05-18_12 40 01

The background color around the feature is black, but the background color around the primary action button is dark grey.

What are the steps to reproduce?

Step 1: Generate What's New using the WhatsNewViewController (I am upgrading from 1.3.7 to current, don't know any SwiftUI yet).

What is the expected behavior?

I expected that the entire WhatsNew background color would be black

SvenTiigi commented 4 months ago

Hi @gaw3,

The background around the primary action button is covered with a UIVisualEffectView that creates a similar UI/UX to Apple's design. This allows the list to scroll under the visual effect view, blurring the content.

https://github.com/SvenTiigi/WhatsNewKit/blob/6157c77e8be9b3d2310bc680681b61a8d9e290ac/Sources/View/WhatsNewView.swift#L97-L102

Currently, there is no option to configure, disable, or remove this visual effect view. Please feel free to open a PR.

SvenTiigi commented 4 months ago

Closing due inactivity. Please feel free to re-open the issue at any time.