search

SvenTiigi / YouTubePlayerKit

A Swift Package to easily play YouTube videos 📺
https://sventiigi.github.io/YouTubePlayerKit/
MIT License
723 stars 64 forks source link

Exposed closing full screen video player method from WKWebView #66

Closed julianjohn closed 1 year ago

julianjohn commented 1 year ago

Firstly, Thank you for this library. 😄

I have a use case where I would like to exit the video from fullscreen programmatically. I researched and found a possible solution. Please take a look.

Note: I am new to the latest Swift features, and every improvement suggestion is welcomed.

SvenTiigi commented 1 year ago

Hi @julianjohn,

Thanks for your PR 👍 An option to invoke the closeAllMediaPresentations API of the WKWebView is a great addition to the YouTubePlayerKit.

After resolving the pending merge conflicts the PR should be good to.

julianjohn commented 1 year ago

@SvenTiigi I think I have fixed the issue. Please check.

SvenTiigi commented 1 year ago

Hi @julianjohn,

Your PR still has a merge conflict with the develop branch. After those conflicts have been resolved the PR should be ready to merge.

julianjohn commented 1 year ago

Resolved for sure this time 😅

julianjohn commented 1 year ago

Do you have any timeline for the next release?

SvenTiigi commented 1 year ago

The changes are now available with the latest version 1.5.0