SvenTiigi / YouTubePlayerKit

A Swift Package to easily play YouTube videos 📺
https://sventiigi.github.io/YouTubePlayerKit/
MIT License
683 stars 61 forks source link

Add additional convenience method for creating a YouTubePlayer.Source from a URL object #87

Closed armadsen closed 5 months ago

armadsen commented 5 months ago

In our app, we already have the urls we want as URL objects, so having to convert them to a string to create a YouTubePlayer.Source only for it to convert back to a URL seemed a bit silly, and took extra code. I changed YouTubePlayer.Source.url() to include versions for both a String and a URL with the String version just calling through to the URL version.

SvenTiigi commented 5 months ago

LGTM 👍

SvenTiigi commented 5 months ago

Changes are available with version 1.8.0