SvenWerlen / moulinette-core

FoundryVTT module which provides a set of tools for DMs for managing assets.
https://www.patreon.com/moulinette
MIT License
41 stars 10 forks source link

Moulinette performs failing HTTP requests, resulting in errors in the console #18

Closed ghost91- closed 3 years ago

ghost91- commented 3 years ago

Moulinette seems to perform some requests that do no necessarily succeed (I suppose it has something to do with the cloud integration stuff). This results in errors popping up in the console, which can be disturbing and and distracting when trying to track down other problem that pop us as actual errors in the console. Here is an example of an error produced by Moulinette:

GEThttps://boisdechet.org/mtte/user/6ecpswuh6k7lpj4e3n8ahhqiat
[HTTP/2 404 Not Found 115ms]

The returned body is just an empty JSON object ({}).

I suggest to find some way to avoid this call.

I guess, personally I would also like a setting to completely deactivate any calls to any 3rd party server. That would also be helpful when running foundry in a LAN only setup, without any internet connection.

SvenWerlen commented 3 years ago

Thank you for your report.

First of all, some clarifications:

ghost91- commented 3 years ago

Thanks for the clarifications, I was assuming it was something like that. And also thanks for being so considerate regarding privacy! I am actually using Moulinette in the way you describe in your last bullet point, so I would be very glad about an option like that :)

Thanks for developing this awesome module btw. :)

SvenWerlen commented 3 years ago

Latest core update (3.3.0) implements the configuration. You can now completely disable Moulinette Cloud if you want to. And there is no more requests to boisdechet.org, only to moulinette.cloud (new domain name). I'm closing this issue. Feel free to re-open it if it doesn't fits your needs.

ghost91- commented 3 years ago

Thank you so much for this!