search

SvenWerlen / moulinette-tiles

Moulinette Forge submodule which provides capabilities for importing and managing tiles
https://www.patreon.com/moulinette
MIT License
2 stars 4 forks source link

crashes while indexing own s3 files #12

Closed Tupsi closed 1 year ago

Tupsi commented 1 year ago

the current version starts indexing fine, but at some point always throws the following in console.

image

deleting that folder and rerunning indexing only put the error at some other directory (in the new scan).

I had used the some structure with items for a while now and had configured indexing it old style like you once told me on discord (with .mtte files), but deleted these and recreated them in your new gui as I saw the "deprecated" warning in the config.

image

I also noticed that clicking the eye (toggle source) does NOT exclude that line from getting indexed (which would be what I had figured the button does), but maybe I just do not get the correct idea of that button, so that might be just a layer 8 problem on my end :-)

Tupsi commented 1 year ago

seems the indexing does not like spaces in names any longer. I put a _ in between Pathfinder Others (which you can see in the first screenshot) and now the indexing runs through.

SvenWerlen commented 1 year ago

Thank you for reporting this! Can you please confirm which version (moulinette-core) do you use? Also which S3 provider?

I tried to reproduce it and wasn't able : image

Tupsi commented 1 year ago

interesting that this just works for you:

i was using wasabi as s3 provider with vtt version 11.301 and moulinette core v 11.1.0.

Tupsi commented 1 year ago

just tested with vtt 11.302 and core v11.1.1 aqnd nothing changed.

what settings are you using in the moulinette dialog?

Tupsi commented 1 year ago

ok, so I found a difference in how you enter the details for the directory in the moulinette gui.

Using "Auto" or Creatarname with * as Pack option does not work here an produces the shown error. Filling out Creator and Pack does not create the error and results in a correct indexing.

image

this worked.

while the next screenshot did not:

image

BUT (and here it gets weird), if you do the working version first (without the error), then get into the gui again and deleted that line (which should delete the indexed part of it as well) this looks fine first (the entry disappears in the dropdown of tiles). But if you now add the line again in the way it should produce the error, the error does not show, the indexing is done and the entry shows again in the dropdown (I suspect you do not really rescan because you never have actually deleted that part in the index).

Now if you completely delete the index with the button on the gui and index again the error shows up again, leaving you without an index,

I hope reading that all makes at least sense in the way that you are able to redo the error on your end.

If you wanna debug that further, full free to bug me on discord. Although our different timezones make that hard, I know. :-)

SvenWerlen commented 1 year ago

This is super useful. I was able to reproduce by using "*" rather than specifying the pack name. I fixed it in moulinette-core v-11.1.2. Feel free to re-open it if you still have an issue with it. Note : yes it is intended that deleting the source won't delete it from the index. You might have other worlds which use the same index and you probably don't want to index multiple times the same sources.