search

SvenskaSpel / locust-plugins

A set of useful plugins/extensions for Locust
Apache License 2.0
526 stars 136 forks source link

Cloudwatch plugin #147

Closed srininara closed 8 months ago

srininara commented 9 months ago

A plugin which will allow locust metrics (request count, response time etc.) to be pushed to AWS cloudwatch (using boto3)

cyberw commented 9 months ago

Is it possible to add a test case that runs the example file? Idk what will happen if there is no endpoint?

cyberw commented 8 months ago

Sorry, I've tried to read this PR, but I just dont understand it and I dont have time to dig into it. Either it needs to be simplified a lot, or I just cant merge it (because people will expect me to support it)

srininara commented 8 months ago

Sorry, I've tried to read this PR, but I just dont understand it and I dont have time to dig into it. Either it needs to be simplified a lot, or I just cant merge it (because people will expect me to support it)

I have tried to add docstrings to individual methods to help make more sense of the code. Please take a look and let me know if it helps. Please do suggest if I can do anything else to help make the PR clear.

cyberw commented 8 months ago

Looks good (in my eyes ;) now. just the linting and test issue I mentioned and we're good to go!

srininara commented 8 months ago

Looks good (in my eyes ;) now. just the linting and test issue I mentioned and we're good to go!

I have tried to address the comments. For linting, I had to override it because the event hook is sending those parameters and I am not using them. Please check and let me know.

cyberw commented 8 months ago

Nice! Thanks!