SvenskaSpel / locust-plugins

A set of useful plugins/extensions for Locust
Apache License 2.0
554 stars 138 forks source link

question: add a target environment discriminator column in timescale and edit the grafana charts to allow target environment selection #182

Closed ionutab closed 4 months ago

ionutab commented 4 months ago

Hello, I'm creating this issue since I have an idea and I want to know if it is good or not. Sorry, it is most likely in the wrong place but I don't know where to ask.

I want to work on extending the current timescale implementation. It would add a "target environment name" configuration and would save that on a column in some db tables as well. At the same time a "target environment" filter would allow Grafana users to view only data from the test runs targeting a specific environment. To keep things backwards compatible, the default would be "default" or "None" or something like that.

The question is: Is this a good idea that would fit into the overall direction of the locust-plugins?

Thanks!

ionutab commented 4 months ago

Nevermind, I just saw the env filter in the Locust Testruns grafana dashboard. I just need to understand what parameter I need to pass in order to the env field to be populated in the testrun database table. I'll solve it sooner or later. Sorry and thank you!

ionutab commented 4 months ago

Hmmm, sorry. I just realized that the --test-env / LOCUST_TEST_ENV configuration is not documented at https://docs.locust.io/en/stable/configuration.html. Is it going to be deprecated?

cyberw commented 4 months ago

--test-env is specific to locust-plugins (so no, its not deprecated :)

ionutab commented 4 months ago

Ah yes, I see, you're right. Thank you!