Closed herrmannplatz closed 4 years ago
Looks OK to me!
Have you done an npm pack
, and installed (npm install path/to/pack.tgz
) and tested it in your gatsby project? Just to make sure that the gatsby.js file is properly included and working. 🙂
If you can do that and get back to me, I'll merge it in and run a release a new version to npm. 👍
As for consolidating, it would be great if they could share some of the code, but it's so little code to begin with, and I worry that if we did that, we'd also have to add like webpack or other horribleness. 🤔
Pretty new at making npm packages, so don't know a lot about what's needed and such to make things usable everywhere. But I do know a single imported file with no dependencies should be pretty safe. 😛
Feel free to squash :)
@herrmannplatz It should be released now, as version 1.4.0
. I released 1.3.0
first, but discovered gatsby.js
wasn't actually in the package. 🤦♂️
I blame you for that, as I guess you didn't run npm pack
. 😜
Did the fix, and re-released, but then messed up some npm stuff, and with npm caching stuff I'm still not sure if it's actually correct, but it does seem like it after I tried another release 1.4.0
. Either way, that stuff I blame myself for, haha.
Running npm pack cypress-hmr-restarter
does download the correct version now, so you should be able to install version 1.4.0
now. 👍
OMG. Thanks for adding. Yes sorry, i tested with npm link. Thanks for fixing! 🎉
Just created a separate file for gatsby. I see room to consolidate this. Open for any ideas.
Closes #7