SwEnt-2024-Group-19 / Activities

1 stars 0 forks source link

Feature/list activities in profile #54

Closed hmaryam84 closed 1 week ago

hmaryam84 commented 2 weeks ago

Features Implemented

1. Lists of Activities in Profile Section

2. Activity Types: PRO, INDIVIDUAL, SOLO

Tests

elvan03 commented 2 weeks ago

The code looks great! Thanks for explaining so clearly the changes you made.

A few things I noticed that could be "improved": For EditProfile, the code for handling the case where the profile is not selected "No profile selected. Should not happen" is repeated 2 times. You could use a function for error messages or just put it in the string.xml file (more generally all strings could be in the string.xml file). In Profile's screen, it could be nice to display a message like "no activities available" for when there are no activities(for example right below "Activities Enrolled in"), a bit like you did ViewListActivities with “There is no activity yet.” Looking forward to the implementation of the tests and the resolving of the merge conflicts. Otherwise LGTM, thanks!