SwEnt-2024-Group-19 / Activities

1 stars 0 forks source link

feat(profile management): Add functions to update profile and delete … #55

Closed GhaliBerbich closed 1 week ago

GhaliBerbich commented 2 weeks ago

…activity from profile

Implement new functions in the ProfileViewModel to support updating the user profile and deleting an activity by its ID. These functionalities extend the ViewModel's capabilities to handle user-specific operations directly from the UI. Corresponding methods have been added to the FirestoreRepository to carry out the actual database operations. Additionally, necessary signatures for these new functions have been introduced in the ProfilesRepository interface to maintain consistency and ensure implementation across any future repositories.

mohamedtahaguelzim commented 2 weeks ago

These should have been pushed with the other PR that needed those functions.

Also, in a more global way, I believe that deleteActivityFromProfile has no reason to exist, as it is a consequence of deleting an activity or un-enrolling from an activity, thus we need to implement it in the deleteActivity or unenroll functions

But for the moment, the PR is very useful as it will fix the compiling issues we currently have in dev branch.

Thanks for the implementation.