search

SwEnt-Group13 / Unio

The world’s largest campus life platform.
3 stars 1 forks source link

Feature/event creation backend #198

Closed Redd87 closed 1 week ago

Redd87 commented 1 week ago

This PR aims to connect the event creation UI to the Firestore database. It modifies the EventCreation file to call eventViewModel.addEvent in the onClick of the create button and does all the required changes for it to work. It enforces a light check on the user arguments (ensures they are non-null and that the startTime < endTime). This is however being put as a draft for the moment as there are no tests at the moment and I'd like to test this with the firebase emulator.

Redd87 commented 1 week ago

The tests with the Firebase emulator are proving harder than expected as I have to pass test tags deep into my components to be able to interact with them, which will need a lot more research. (e.g. for the date picker dialog, in order to enter a date I need to be able to click on a specific date in the date picker dialog, which is not doable as I'd have to put a test tag in a material component directly to interact with it). That being said the rest of the PR is entirely functional which is why I would like the team to review it.

sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions
31.08% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud