search

SwEnt-Group13 / Unio

The world’s largest campus life platform.
3 stars 1 forks source link

Adapt the "following" feature to work in offline mode #214

Closed Romainhir closed 4 days ago

Romainhir commented 6 days ago

There are multiple feature that do not work in offline mode. The "following" feature is one of them.

The user has to leave the screen and come back for the button to be clickable again, and the follow count isn't increased. When you follow an association, two repositories are essentially called in ConcurrentAssociationUserRepositoryFirestore, which runs the calls in a runBatch. I suspect this batch operation is the issue, and has to be handled differently to work with offline mode, or another operation should be done after to fix the bug.

Romainhir commented 5 days ago

See #212 for more details

sonarcloud[bot] commented 5 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Romainhir commented 4 days ago

Nice fix ! I think it is also present in your other PR for the password management. Anyhow Looks good to me !

It's a bug because I implemented these PR concurrently. This should be removed from the other PR when this one will be merged on main.