SwEnt-Group13 / Unio

The world’s largest campus life platform.
3 stars 1 forks source link

Implement password reset functionnality #219

Closed Romainhir closed 3 days ago

Romainhir commented 4 days ago

Currently, once an account has been created, it is not possible to change the password in the app. This task aims to ass password reset functionnality on the account profile of the user. Precisely, this will send an email to the user with a link where they can modify his password. This does not allow a user to change it in the Welcome Screen. This can be done in another task.

Edit : I also added the task to reset the password from the Welcome screen in this PR, because it makes more sens to me to merge them in the same time

AlouchLaBouche commented 4 days ago

By the way we noticed with @oskar-codes that there exists a method to change the password with firebase auth updatePassword see the documentation. This can be a better use for changing the password when signed in. Furthermore, I have already done the UI for the forgot password screen, see the figma, so we can quickly implement it and merge everything to main.

Romainhir commented 4 days ago

By the way we noticed with @oskar-codes that there exists a method to change the password with firebase auth updatePassword see the documentation. This can be a better use for changing the password when signed in. Furthermore, I have already done the UI for the forgot password screen, see the figma, so we can quickly implement it and merge everything to main.

So how do you see the thing ? Should I still merge this to main and we will make the change later or should we put our code in the same PR ?

AlouchLaBouche commented 4 days ago

I think we can see each other tomorrow @Romainhir and quickly add my forgot password screen UI to your PR and then merge it :+1: .

sonarcloud[bot] commented 3 days ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
65.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud