search

SwEnt-Group13 / Unio

The world’s largest campus life platform.
3 stars 1 forks source link

Feature/edit and delete event #223

Closed Redd87 closed 2 days ago

Redd87 commented 4 days ago

This PR adds on the events of the association profile page the ability to edit or delete an event.
There are currently no tests and a there is a synchronization problem between the AssociationViewModel and the firestore database when creation, editing or deleting an event, which is why this PR is currently a draft.

Redd87 commented 3 days ago

The PR is now open for review! There is still the synchronization problem between the ViewModel and the database, but this will be fixed in a future PR as it doesn't affect the functionality of this one and it is large enough as is. This PR includes: EventEdit.kt - allowing the user to edit or delete an existing event EventEditComponents.kt - a utils file that extracts components common to EventEdit and EventCreation EventEditTests - a file that tests for test tags as well as basic functionality checks New test tags and tests for EventCreation An edit event button in EventCard New test tags and test for EventCard Some documentation improvements Modifications in the appropriate files to accommodate the new signatures

sonarcloud[bot] commented 2 days ago

Quality Gate Failed Quality Gate failed

Failed conditions
79.84% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud