search

SwEnt-Group13 / Unio

The world’s largest campus life platform.
3 stars 1 forks source link

feat(explore): add association interaction to go to the association profile screen #39

Closed Zafouche closed 1 week ago

Zafouche commented 1 week ago

Ultimately, some things had to be changed for this to be possible:

  1. Modified the navigation system, such that it correctly handles and recognizes screen hierarchy (reminder: only the parent screen should have a route)
  2. Added the interaction to the association items to bring us to the association profile screen. Ultimately, in the future, we will have to keep a state as to which association was selected such that we know which association's profile we display.
  3. Added a "go back" button to the association profile screen as it is a child screen of the explore screen.
Zafouche commented 1 week ago

Will add tests tomorrow morning.

sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions
51.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Zafouche commented 1 week ago

Will add tests for the explore screen and the navigation system in different PRs. However I don't see how to improve the code coverage on AssociationProfile.kt.

oskar-codes commented 1 week ago
  1. Added the interaction to the association items to bring us to the association profile screen. Ultimately, in the future, we will have to keep a state as to which association was selected such that we know which association's profile we display.

The option you mention is feasible, however I believe there is a way to create routes with arguments, maybe it's something to consider. See this.

Zafouche commented 1 week ago
  1. Added the interaction to the association items to bring us to the association profile screen. Ultimately, in the future, we will have to keep a state as to which association was selected such that we know which association's profile we display.

The option you mention is feasible, however I believe there is a way to create routes with arguments, maybe it's something to consider. See this.

I will have a look

Zafouche commented 1 week ago

We will do this in sprint 2 in a different PR.