SwEnt-Group13 / Unio

The world’s largest campus life platform.
3 stars 1 forks source link

chore(association): add generic functions to the repository of the associations. #41

Closed Zafouche closed 1 week ago

Zafouche commented 1 week ago

This includes:

This will be useful when a new association signs-up to our service or modifies some of its data. I added a delete function in case some associations dissolves or leaves our service.

Zafouche commented 1 week ago

I just realized I misnamed the branch, it should be chore/association-repository.

sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions
57.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Zafouche commented 1 week ago

We will refactor and find a way for the two first functions to use the general performFirestoreOperation in a different PR. Probably by making the function generic.

Zafouche commented 1 week ago

I have reviewed your changes and found the implementation to be clear and well-organized. The code adheres to best practices, and all functionality has been tested successfully. I’m pleased to approve this pull request, and I appreciate your continued dedication to maintaining a high standard of quality.

Dear collaborator,

I thank you for your message, and I am thankful for the time you put in reviewing this new code. I appreciate the value you bring in both your PRs and code reviews.

Until the next code review,

Zafouche