oskar-codes
commented
1 week ago The previous 9 commits aim to resolve the issues raised by @Zafouche. The branch should be ready to be merged.
Closed oskar-codes closed 1 week ago
oskar-codes
commented
1 week ago The previous 9 commits aim to resolve the issues raised by @Zafouche. The branch should be ready to be merged.
Zafouche
commented
1 week ago The previous 9 commits aim to resolve the issues raised by @Zafouche. The branch should be ready to be merged.
Perfect thank you for this!
sonarcloud[bot]
commented
1 week ago 
Quality Gate failedFailed conditions
49.1% Coverage on New Code (required ≥ 80%)
⚠️ Important considerations before merging ⚠️
This pull requests aims to implement the sign-in and account creation process of Unio. It is fully functional, but it is not aligned with the decisions made with the team beforehand. Most notably, this change does not restrict epfl.ch email domains. This is because:
So in the end, the only remaining system is simply Firebase Email/Password auth with email verification, but sadly no epfl.ch domain restriction. I hope the email verification system will still make our platform a user-friendly place with no/less spam.
Note also that this authentication system is subject to change, if the IT Desk allows us to use their login system or if we find another solution.
On another note, the Figma Design page was updated to match the new sign in/up flow that arises from these constraints. I have reviewed these changes with the lead UI/UX designer @Redd87.