SwEnt-Group13 / Unio

The world’s largest campus life platform.
3 stars 1 forks source link

chore(association/profile): implement passage of selected association's uid to the association profile screen #61

Closed Zafouche closed 1 week ago

Zafouche commented 1 week ago

Description

Motivation

This PR implements the method of passing the selected association's uid to the association profile screen using Jetpack Navigation arguments. This approach follows what's explained in this article. This allows us to get the data of the association profile that has to be displayed on the association profile screen (AssociationProfile.kt)

Considerations

Note

You cannot yet play around with it, as the view model is not yet used in the explore screen. I will work on using it on a different PR, and come back to this one, pull the changes on this branch so we can test this by hand as well. Tests are also not yet written as I am not sure this method is better than the one used in the bootcamp.

Zafouche commented 1 week ago

None of the tests have been tampered with as I need opinions on which method we should use.

Zafouche commented 1 week ago

I will sync this branch with the main branch.

Zafouche commented 1 week ago

I ended up simply changing the String value of the ASSOCIATION_PROFILE like @oskar-codes suggested and added the helper function the Screen object. More tests are yet to come.

sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions
66.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Zafouche commented 1 week ago

Not sure what else can be tested. @Romainhir will need the changes done to implement the association profile screen further. Does this look good for you to merge? @oskar-codes @Redd87