Refactor/user data class - Githubissues

SwEnt-Group13 / Unio

The world’s largest campus life platform.

3 stars 1 forks source link

Refactor/user data class #95

Closed AlouchLaBouche closed 1 day ago

AlouchLaBouche commented 1 day ago

This PR includes the refactored user data class, new navigation logic and all the refactoring needed for the tests. For the user data class I added 2 new fields, those being : joinedAssociations and hasProvidedAccountDetails, for the following reasons:

It is now possible to see what associations a user is part of.
The latter is to ensure correct navigation logic. If in the user has not completed giving his account details but has verified his email, he will be redirected to the AccountDetails Screen instead of straight to Home.

Potential Risks:

The joinedAssociations Reference List might be desynced with the members Reference List found in the association data class. (We partly loose the SSOT concept).

sonarcloud[bot] commented 1 day ago

Quality Gate failed

Failed conditions
63.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud