comments and conditionals are not treated differently

Swaagie / minimize

Minimize HTML

MIT License

162 stars 18 forks source link

comments and conditionals are not treated differently #34

Closed ghost closed 9 years ago

ghost commented 9 years ago

Keeping one true is the same as keeping the other, or both, true (i.e. {comments: true} == {conditions: true}).

I know this was done on purpose to clean up the comments logic, but it seems like a punt. Can we go back to treating these two different?

Swaagie commented 9 years ago

I agree with you on this one, will check it out asap

Swaagie commented 9 years ago

Published as 1.3.1, I assumed you wanted to remove comments and keep conditionals here, the same goes for server side includes now. Only comments: true will keep all around

ghost commented 9 years ago

Awesome, I'll mark this in #17.