search

Swaagie / minimize

Minimize HTML
MIT License
162 stars 18 forks source link

autocomplete="off" is changed to autocomplete which is opposite of meaning. #42

Closed gambrose closed 9 years ago

gambrose commented 9 years ago

I have the following html

<input autocomplete="off">

autocomplete="off" is set to prevent the browser suggesting entries in a dropdown. I want to provide my own drop down using javascript.

When minimised I get

<input autocomplete>

Which is not semantically equivalent as this turns on autocomplete

Swaagie commented 9 years ago

Good spot, thx for reporting, the easiest fix would be to remove https://github.com/Moveo/minimize/blob/master/lib/list.js#L28 from the redundant list for now, I was not aware providing it with "off" instead of false was possible.

Swaagie commented 9 years ago

published fix with version 1.4.0

gambrose commented 9 years ago

Thanks for the quick fix.