search

Swaagie / minimize

Minimize HTML
MIT License
162 stars 18 forks source link

Save dom #59

Closed alexander-akait closed 8 years ago

alexander-akait commented 8 years ago

https://github.com/Swaagie/minimize/issues/58 If you agree with these decisions, I'll write tests Also this solved problem https://github.com/murphydanger/gulp-minify-html/issues/37

Swaagie commented 8 years ago

First of all, sorry for the late reply was on holiday the last week. I can understand the line of reasoning, however it doesn't feel like this belongs in the module's code. I think it's to specific and not a general use case. The applied fix can be done in 'userland' code as well. E.g. manually add the <endoffile></endoffile> to your content, remove the once:parse listener from your instantiated minimize and reattach a new once:parse listener that has the custom replace.

Swaagie commented 8 years ago

Closing this due to inactivity and above explained reasons