search

SwagLyrics / SwSpotify

Cross-platform library to get the currently playing song and artist from Spotify w/o using the API or the internet. Very fast.
MIT License
85 stars 12 forks source link

Fix #15 #16

Closed musabkilic closed 4 years ago

musabkilic commented 4 years ago

This pull request fixes the problem stated in #15 by checking if the window title equals 'Spotify'

codecov[bot] commented 4 years ago

Codecov Report

Merging #16 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   68.49%   68.49%           
=======================================
  Files           2        2           
  Lines          73       73           
  Branches        9        9           
=======================================
  Hits           50       50           
  Misses         21       21           
  Partials        2        2
Impacted Files Coverage Δ
SwSpotify/spotify.py 75.75% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8652ac3...79d62e3. Read the comment docs.

aadibajpai commented 4 years ago

I was thinking maybe we could use startswith 😉

musabkilic commented 4 years ago

I thought about that too!! I was curious what would you think about that. Let me fix that 🙂