search

SwagLyrics / SwagLyrics-Chrome-Extension

Chrome extension to make SwSpotify and by extension swaglyrics work for the Spotify Web Player.
7 stars 4 forks source link

Make it independent from swspotify. #9

Open xatuke opened 4 years ago

xatuke commented 4 years ago

Why?

img

Where?

img

How to fix senpai?

img

How actually?

Write the same requests which are used for getting the lyrics on swaglyrics cli on the chrome extension, ez fix.

aadibajpai commented 4 years ago

@flabbet I know we should do this eventually but this also involves making a nice UI on the right and rewriting the swaglyrics core in JS.

thoughts?

flabbet commented 4 years ago

we could do that, but it's a bit of work and I don't have time and will to do that. Let's make it hacktoberfest thing and let people do that

aadibajpai commented 4 years ago

If you'd like to work on this, a UI like Netflix Party would be very interesting. Even SwagLyrics on Firefox Side View looks pretty nice w/o the extra scrollbars and stuff.

image

flabbet commented 4 years ago

Sure, but this is not what extension is for

flabbet commented 4 years ago

The extension is a bridge for SwagLyrics-For-Spotify, so it can support the Spotify browser. This is not a good idea to make console lyrics.

aadibajpai commented 4 years ago

I agree with @flabbet here, @crowded-geek. Your issue is actually two separate things,

bug: the chrome extension spams local requests which floods network logs

feature request: standalone version of the chrome extension

now this isn't the same thing since SwSpotify is consumed by other python libraries as well which might wish to use the extension to extend support for Spotify Web.

so even if we implement a standalone version, I don't think we can stop the bug.

xatuke commented 4 years ago

The fact still stays that the chrome extension doesn't need to use SwSpotify. I have no idea why was it connected to it in the first place. We can just scrape the current song data from the spotify tab, get lyrics and show them.

aadibajpai commented 4 years ago

The fact still stays that the chrome extension doesn't need to use SwSpotify. I have no idea why was it connected to it in the first place. We can just scrape the current song data from the spotify tab, get lyrics and show them.

extension doesn't need SwSpotify but SwSpotify needs the chrome extension, it's meant to extend support for SwSpotify.

For example, suppose you create a python application that interacts with Spotify and you use SwSpotify, now how do you make it support the Spotify Web Player w/o the Chrome Extension?