search

SwagLyrics / SwagLyrics-For-Spotify

📃 Get lyrics of currently playing Spotify song so you don't sing along with the wrong ones and embarrass yourself later. Very fast.
https://pypi.org/project/swaglyrics/
MIT License
320 stars 36 forks source link

[IMPORTANT BUG] Genius A/B testing breaks swaglyrics #2326

Closed aadibajpai closed 4 years ago

aadibajpai commented 4 years ago

Describe the bug Genius has been trying to roll out a new interface https://genius.com/discussions/377926-The-2020-genius-song-page-redesign which looks bad and messes up swaglyrics

The difference between when current swaglyrics works and when it doesn't looks like this: https://www.diffchecker.com/86R8HIfM (left is success, right is failure) but the thing is both of them have lyrics so we need to do stuff fast

To Reproduce Steps to reproduce the behavior: You literally can't because it's random

This is the topmost priority rn

aadibajpai commented 4 years ago

https://github.com/SwagLyrics/SwagLyrics-For-Spotify/commit/0a73b1285cb243f019b8d946845a7191e4ff0ec2 this should work so if anyone is seeing this, build swaglyrics from master until I make it better and roll out a proper release

aadibajpai commented 4 years ago

Fixed https://github.com/SwagLyrics/SwagLyrics-For-Spotify/releases/tag/v1.2.0