SwagLyrics / SwagLyrics-For-Spotify

📃 Get lyrics of currently playing Spotify song so you don't sing along with the wrong ones and embarrass yourself later. Very fast.
https://pypi.org/project/swaglyrics/
MIT License
320 stars 35 forks source link

[FEATURE] WSL2 Support / Move away from dbus #2828

Open danaimone opened 3 years ago

danaimone commented 3 years ago

Is your feature request related to a problem? Please describe. SwagLyrics currently has dbus-daemon issues when trying to use WSL2 & Ubuntu to run the program. dbus.exceptions.DBusException: org.freedesktop.DBus.Error.NotSupported: Unable to autolaunch a dbus-daemon without a $DISPLAY for X11

Describe the solution you'd like Support for WSL2, without the use of dbus. Dbus is not the best package to use in a case for compatibility, and process communication might be better achieved through the use of sockets (although you could make a GET request and process the lyrics JSON data and negate the need for Dbus altogether).

Describe alternatives you've considered I somewhat described an alternative solution to how data is fetched in this app (I haven't taken too close of a look at the source code), but I question why dbus is needed for simple CLI operation. I'd be surprised if Genius didn't have a REST API to fetch lyrics easily, unless dbus is used for catching the current song playing. In the latter case, I would need to do some research as to how you could fetch the current song playing in your Spotify (could probably be accomplished using their API). I personally believe this app could be made into a GUI application that acts as a "mini" player with lyric capability, as I feel a lot of Spotify users are still sore from losing the lyrics option on the desktop client.

Additional context None.