search

Swamp-Ig / pizone

Python interface to iZone aircon controller.
GNU General Public License v3.0
12 stars 11 forks source link

Provide support for AirFlowMin/AirFlowMax command #6

Closed Nick-Adams-AU closed 3 years ago

Nick-Adams-AU commented 3 years ago

Hi @Swamp-Ig,

This is my first PR so please go easy on me!

I wanted to support the AirFlowMin/AirFlowMax command in your HA integration. I have refactored the zone _send_zone_command function to allow it to be used for the AirFlowMin/max calls as they are structurally the same.

Are you able to check if the code looks ok please?

Swamp-Ig commented 3 years ago

Also, thanks so much for contributing! Much appreciated.

njoc-dev commented 3 years ago

@Nick-Adams-AU I have a V2 system so if you want someone to test for compatibility let me know

Nicko

Swamp-Ig commented 3 years ago

@Nick-Adams-AU Can you please add some code to the test case too and do a new PR? I'm @Penny on the discord for HA if you want to chat directly.

Nick-Adams-AU commented 3 years ago

Thanks for that merge! I'll have a look at the tests now.

I also have a matching HA component PR ready to go with similar functionality once this is "released". Is there much involved in pushing a release?

Swamp-Ig commented 3 years ago

Nah not really, just a matter of updating the version number, tagging, building, and uploading it to pypi

Will do this once the test case is done and working.