SwapnikKatkoori / sleeper-api-wrapper

A Python wrapper for the Sleeper Fantasy Football API.
MIT License
67 stars 19 forks source link

Update requests requirement #21

Open wfordh opened 3 years ago

wfordh commented 3 years ago

Updating the requests requirement to be ">=2.22.0" instead of "=2.22.0" in order to avoid urllib3 vulnerability outlined here. After changing the files, I installed the package locally and was able to successfully run the following functions:

I did not change the package version in setup.py, but that could be folded in easily if you think it should be.

yaleman commented 2 years ago

@SwapnikKatkoori please merge and update the library 🙏🏻

dtsong commented 2 years ago

Hmm, given that there hasn't been much traffic or activity in this GitHub repo since 2019 and it is under the MIT License, would it make sense to make a fork and new home for changes? I am open to doing something like that since I think it would open so much potential for development to have a Python wrapper like this around the Sleeper API.

dtsong commented 2 years ago

I'll see what I can do to get some of this rolling in the coming weekend since I will have some time to get some Sleeper API related development going, definitely happy to add you guys as collaborators for the forked repo here if you wish to make PRs and whatnot:

https://github.com/dtsong/sleeper-api-wrapper

@yaleman @wfordh

Definitely happy to cross the changes over to this repo if @SwapnikKatkoori wishes this to be the home for the code, but happy to also help general development effort continue cuz I can definitely see lots of potential with this library

wfordh commented 2 years ago

@dtsong not sure how much time I'll have to contribute, but happy to help out where possible since I'm at least a little familiar with the code from working with this original repo

dtsong commented 2 years ago

sounds good @wfordh, feel free to raise this pull request against my repository (https://github.com/dtsong/sleeper-api-wrapper), will definitely take a look along with possibly getting the other pull requests raised / establish all the good CICD stuff to ensure we're not introducing breaking changes and whatnot

yaleman commented 2 years ago

Just note that as your repo's a fork, if @SwapnikKatkoori deletes theirs, yours goes too (obviously you could recreate it from local code)

dtsong commented 2 years ago

Oh, good to know, thanks @yaleman. I'll make a new code repo in that case, didn't know that about repo forks.

Un-forked the repo here: https://github.com/dtsong/sleeper-api-wrapper

SwapnikKatkoori commented 2 years ago

@dtsong really appreciate you doing this. Will put a link to your repo in the readme to this project.

dtsong commented 2 years ago

No problem @SwapnikKatkoori, thank you for getting things going to begin with and looking forward to the upside that a codebase like this can bring just like the incoming NFL rookies running in the Combine :)